From 5cb880021cf58cd8be7dbbb19bcf878f797c44a5 Mon Sep 17 00:00:00 2001 From: Zhe Fang Date: Sat, 22 Nov 2025 09:38:49 -0500 Subject: [PATCH] fix: add error parser placeholder --- .../BetterLyrics.WinUI3/Models/LyricsData.cs | 13 ++++--------- .../Parsers/LyricsParser/LyricsParser.cs | 7 ++++++- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/BetterLyrics.WinUI3/BetterLyrics.WinUI3/Models/LyricsData.cs b/BetterLyrics.WinUI3/BetterLyrics.WinUI3/Models/LyricsData.cs index a87f6f3..cdbda9c 100644 --- a/BetterLyrics.WinUI3/BetterLyrics.WinUI3/Models/LyricsData.cs +++ b/BetterLyrics.WinUI3/BetterLyrics.WinUI3/Models/LyricsData.cs @@ -131,25 +131,23 @@ namespace BetterLyrics.WinUI3.Models return result; } - public static LyricsData GetNotfoundPlaceholder(int durationMs) + public static LyricsData GetNotfoundPlaceholder() { return new LyricsData([new LyricsLine { StartMs = 0, - EndMs = durationMs, + EndMs = (int)TimeSpan.FromMinutes(99).TotalMilliseconds, OriginalText = _resourceService.GetLocalizedString("LyricsNotFound"), - LyricsChars = [], }]); } - public static LyricsData GetParseErrorPlaceholder(int durationMs) + public static LyricsData GetParseErrorPlaceholder() { return new LyricsData([new LyricsLine { StartMs = 0, - EndMs = durationMs, + EndMs = (int)TimeSpan.FromMinutes(99).TotalMilliseconds, OriginalText = _resourceService.GetLocalizedString("LyricsParseError"), - LyricsChars = [], }]); } @@ -160,10 +158,7 @@ namespace BetterLyrics.WinUI3.Models { StartMs = 0, EndMs = (int)TimeSpan.FromMinutes(99).TotalMilliseconds, - PhoneticText = "", OriginalText = "● ● ●", - TranslatedText = "", - LyricsChars = [], }, ]); } diff --git a/BetterLyrics.WinUI3/BetterLyrics.WinUI3/Parsers/LyricsParser/LyricsParser.cs b/BetterLyrics.WinUI3/BetterLyrics.WinUI3/Parsers/LyricsParser/LyricsParser.cs index 012fb94..a715195 100644 --- a/BetterLyrics.WinUI3/BetterLyrics.WinUI3/Parsers/LyricsParser/LyricsParser.cs +++ b/BetterLyrics.WinUI3/BetterLyrics.WinUI3/Parsers/LyricsParser/LyricsParser.cs @@ -24,7 +24,7 @@ namespace BetterLyrics.WinUI3.Parsers.LyricsParser LyricsDataArr = []; if (string.IsNullOrWhiteSpace(lyricsSearchResult?.Raw)) { - LyricsDataArr.Add(LyricsData.GetNotfoundPlaceholder((int)(songInfo?.DurationMs ?? 0))); + LyricsDataArr.Add(LyricsData.GetNotfoundPlaceholder()); } else { @@ -46,6 +46,11 @@ namespace BetterLyrics.WinUI3.Parsers.LyricsParser default: break; } + + if (LyricsDataArr.Count == 0) + { + LyricsDataArr.Add(LyricsData.GetParseErrorPlaceholder()); + } } LoadTranslation(lyricsSearchResult); LoadTransliteration(lyricsSearchResult);